GtkButton: don't do string compare on property set
authorRyan Lortie <desrt@desrt.ca>
Mon, 9 Jan 2012 14:21:18 +0000 (15:21 +0100)
committerMatthias Clasen <mclasen@redhat.com>
Wed, 11 Jan 2012 05:26:56 +0000 (00:26 -0500)
Just set the property unconditionally.

https://bugzilla.gnome.org/show_bug.cgi?id=667394

gtk/gtkbutton.c

index cc159c45a67a28dc59156d085d450ad2e1bf21f9..564483bae2532e6d00ae467291479f0f48f65f81 100644 (file)
@@ -734,15 +734,12 @@ gtk_button_set_action_name (GtkActionable *actionable,
   g_return_if_fail (GTK_IS_BUTTON (button));
   g_return_if_fail (button->priv->action == NULL);
 
-  if (g_strcmp0 (action_name, button->priv->action_name) != 0)
-    {
-      g_free (button->priv->action_name);
-      button->priv->action_name = g_strdup (action_name);
+  g_free (button->priv->action_name);
+  button->priv->action_name = g_strdup (action_name);
 
-      gtk_button_update_action_observer (button);
+  gtk_button_update_action_observer (button);
 
-      g_object_notify (G_OBJECT (button), "action-name");
-    }
+  g_object_notify (G_OBJECT (button), "action-name");
 }
 
 static void